netdev - RE: [net-next patch] bnx2x: Define bnx2x_tests_str

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Jun 2012 15:45:10 +0300
From:	"Merav Sicron" <meravs@...adcom.com>
To:	"David Laight" <David.Laight@...LAB.COM>
cc:	davem@...emloft.net, netdev@...r.kernel.org, eilong@...adcom.com
Subject: RE: [net-next patch] bnx2x: Define bnx2x_tests_str_arr as const

On Wed, 2012-06-27 at 12:59 +0100, David Laight wrote:
> > -static char *bnx2x_tests_str_arr[BNX2X_NUM_TESTS_SF] = {
> > +static const char *bnx2x_tests_str_arr[BNX2X_NUM_TESTS_SF] = {
> >  	"register_test (offline)    ",
> >  	"memory_test (offline)      ",
> >  	"int_loopback_test (offline)",
> 
> You are still missing a 'const'.
> You probably want:
>   static const char *const bnx2x_tests_str_arr[] ...
> 
> However if you are going to pad the strings to [28]
> you might as well remove the layer of indirection - ie:
>   static const char bnx2x_tests_str_arr[BNX2X_NUM_TESTS_SF][28] = { ...
> }
> Or pad to 32 chars to (probably) remove some code bytes.
> 
> 	David
> 
Thanks David, let me think about it.
Dave, please ignore this patch for now.
Thanks,
Merav



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html