| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 Jun 2012 22:04:59 -0700 (PDT) From: David Miller <davem@...emloft.net> To: mchan@...adcom.com Cc: netdev@...r.kernel.org, nsujir@...adcom.com Subject: Re: [PATCH v2 -next 4/4] tg3: Add binary sysfs file to export bulk sensor data From: "Michael Chan" <mchan@...adcom.com> Date: Tue, 26 Jun 2012 22:00:49 -0700 > On Tue, 2012-06-26 at 21:02 -0700, David Miller wrote: >> Ben stated merely that a binary attribute existed for sysfs files. He >> did not, however, say that this is the path down which you should >> implement your feature. > > He said that if the data was difficult to parse in the driver, then a > binary sysfs or private ioctl (which we would stay away) would be > appropriate. There are hundreds of bytes of this data, most of which is > not useful to the user but needed for Lights out management. It will > greatly bloat the tg3 driver to add code to parse all that data and > export each one separately. I don't want us to get into the habit of just going "oh it's LOM stuff, binary blob." And that's the precedence you're setting here. It also sets up a situation where functionality could end up only being available in proprietary binary only tools. It's not like this is some standardized format like a DMI table or similar, is it? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists