netdev - Re: [PATCH 1/4] asix: Fix checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Jul 2012 14:43:19 -0700
From:	Grant Grundler <grundler@...omium.org>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Christian Riesch <christian.riesch@...cron.at>,
	netdev@...r.kernel.org, Oliver Neukum <oneukum@...e.de>,
	Eric Dumazet <edumazet@...gle.com>,
	Allan Chou <allan@...x.com.tw>,
	Mark Lord <kernel@...savvy.com>,
	Ming Lei <tom.leiming@...il.com>,
	Michael Riesch <michael@...sch.at>
Subject: Re: [PATCH 1/4] asix: Fix checkpatch warnings

On Fri, Jul 6, 2012 at 4:58 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Fri, 2012-07-06 at 13:33 +0200, Christian Riesch wrote:
>> Signed-off-by: Christian Riesch <christian.riesch@...cron.at>
>> ---
>
>> -             netdev_err(dev->net, "Error reading PHYID register: %02x\n", ret);
>> +             netdev_err(dev->net, "Error reading PHYID register: %02x\n",
>> +                        ret);
>
>
> Thats ridiculous

Agreed. But it's not Christian's fault and I'm pretty sure you aren't
blaming him.

> Not all checkpatch warnings are meaningful.

Agreed.

> I mean, they probably are for new code, but for existing one this is a
> waste of time.

Christian is clearly running checkpatch.pl as suggested in
Documentation/SubmittingPatches. He missed the part about "You should
be able to justify all violations that remain in your patch." and/or
didn't know about "fixing existing code is a waste of time".

Given the extent of the changes Christian is making (factoring out
asix common code from model specific code), it's helpful to have clean
checkpatch runs. I don't believe it's a waste of time to apply this
patch. Is it conflicting with any other code changes that are in
flight now?

thanks,
grant
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html