netdev - Re: [PATCH 2/4] phylib: add context argument to adjust link callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 6 Jul 2012 23:39:09 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	<s-paulraj@...com>
CC:	<netdev@...r.kernel.org>, <davem@...emloft.net>, <cyril@...com>,
	<grant.likely@...retlab.ca>, <linux-keystone@...t.ti.com>
Subject: Re: [PATCH 2/4] phylib: add context argument to adjust link callback

On Fri, 2012-07-06 at 16:09 -0400, s-paulraj@...com wrote:
> From: Sandeep Paulraj <s-paulraj@...com>
> 
> This patch introduces a context argument for the adjust link callback.  This
> context information is set at phy_connect() (and its variants), and is passed
> back into the adjust_link callbacks on link state change events.
> 
> Such context information is necessary when a network device has multiple
> underlying ports.  Specifically, this comes into play when the netdev is
> really one of the ports going into an on-chip switch of some sort.
[...]

I have no particular opinion on the interface change, but the tree
should be compilable after each commit.  So patches 2-4 need to be
squashed together or otherwise refactored so that this is true.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html