netdev - RE: [patch] qlge: fix an "&&" vs "||" bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Jul 2012 11:15:56 -0700
From:	Jitendra Kalsaria <jitendra.kalsaria@...gic.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	Anirban Chakraborty <anirban.chakraborty@...gic.com>
CC:	Ron Mercer <ron.mercer@...gic.com>,
	Dept-Eng Linux Driver <Linux-Driver@...gic.com>,
	netdev <netdev@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [patch] qlge: fix an "&&" vs "||" bug

-----Original Message-----
>From: Dan Carpenter [mailto:dan.carpenter@...cle.com] 
>Sent: Thursday, July 12, 2012 7:47 AM
>To: Anirban Chakraborty
>Cc: Jitendra Kalsaria; Ron Mercer; Dept-Eng Linux Driver; netdev; kernel-janitors@...r.kernel.org
>Subject: [patch] qlge: fix an "&&" vs "||" bug
>
>The condition is always true so WOL will never work.
>
>Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>
>diff --git a/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c b/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c
>index 3d4462b..6f316ab 100644
>--- a/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c
>+++ b/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c
>@@ -440,7 +440,7 @@ static int ql_set_wol(struct net_device *ndev, struct ethtool_wolinfo *wol)
> 	unsigned short ssys_dev = qdev->pdev->subsystem_device;
> 
> 	/* WOL is only supported for mezz card. */
>-	if (ssys_dev != QLGE_MEZZ_SSYS_ID_068 ||
>+	if (ssys_dev != QLGE_MEZZ_SSYS_ID_068 &&
> 			ssys_dev != QLGE_MEZZ_SSYS_ID_180) {
> 		netif_info(qdev, drv, qdev->ndev,
> 				"WOL is only supported for mezz card\n");

Acked-by: Jitendra Kalsaria <jitendra.kalsaria@...gic.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html