lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Jul 2012 09:53:35 +0800 From: Li Wei <lw@...fujitsu.com> To: Stephen Hemminger <shemminger@...tta.com> CC: "David S. Miller" <davem@...emloft.net>, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH] ipv6: fix incorrect route 'expires' value passed to userspace. δΊ 2012-7-17 0:41, Stephen Hemminger ει: > On Mon, 16 Jul 2012 16:09:37 +0800 > Li Wei <lw@...fujitsu.com> wrote: > >> diff --git a/net/ipv6/route.c b/net/ipv6/route.c >> index becb048..a7fec9d 100644 >> --- a/net/ipv6/route.c >> +++ b/net/ipv6/route.c >> @@ -2516,7 +2516,7 @@ static int rt6_fill_node(struct net *net, >> goto nla_put_failure; >> if (!(rt->rt6i_flags & RTF_EXPIRES)) >> expires = 0; >> - else if (rt->dst.expires - jiffies < INT_MAX) >> + else if ((int)(rt->dst.expires - jiffies) < INT_MAX) >> expires = rt->dst.expires - jiffies; >> else >> expires = INT_MAX; > > Why not use time_is_after_jiffies() macro? time_is_after_jiffies() return a bool but we need "how much time before/after jiffies" here. > > However, I also think these code seems a little ugly, because we need to store the result of two "unsigned long"'s subtraction into an integer. Maybe we should distinguish expires before and after jiffies to proper process the overflows. Thanks, Wei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists