lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 18 Jul 2012 09:23:46 -0700 (PDT) From: David Miller <davem@...emloft.net> To: hayeswang@...ltek.com Cc: romieu@...zoreil.com, eric.dumazet@...il.com, netdev@...r.kernel.org Subject: Re: [RFC] r8169 : why SG / TX checksum are default disabled From: hayeswang <hayeswang@...ltek.com> Date: Wed, 18 Jul 2012 14:45:55 +0800 > Francois Romieu [mailto:romieu@...zoreil.com] > [...] > >> Hayes, should we not add into the kernel driver something similar to >> the rtl8168_start_xmit::skb_checksum_help stuff in Realtek's >> 8168 driver ? >> There seems to be a bug for (skb->len < 60 && RTL_GIGA_MAC_VER_34. > > For RTL8168E-VL (RTL_GIGA_MAC_VER_34), the hardware wouldn't send the packet > with the length less than 60 bytes. The hardware should pad this kind of packet > to 60 bytes, but it wouldn't. Therefore, the software has to pad the packet to > 60 bytes. However, the hw checksum would be incorrect for the modified packet, > so the software checksum is necessary. I wonder how the hardware checksum can be incorrectly calculated if the padding is done with zeros? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists