netdev - RE: [PATCH] be2net: Missing byteswap in be_get_fw_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Jul 2012 12:18:42 +0000
From:	<Sathya.Perla@...lex.Com>
To:	<anton@...ba.org>, <subbu.seetharaman@...lex.com>,
	<Ajit.Khaparde@...lex.Com>, <netdev@...r.kernel.org>
Subject: RE: [PATCH] be2net: Missing byteswap in be_get_fw_log_level causes
 oops on PowerPC

>-----Original Message-----
>From: Anton Blanchard [mailto:anton@...ba.org]
>
>We are seeing an oops in be_get_fw_log_level on ppc64 where we walk
>off the end of memory.
>
>commit 941a77d582c8 (be2net: Fix to allow get/set of debug levels in
>the firmware.) requires byteswapping of num_modes and num_modules.
>
>Cc: stable@...r.kernel.org # 3.5+
>Signed-off-by: Anton Blanchard <anton@...ba.org>
Acked-by: Sathya Perla <sperla@...lex.com>

Thanks for the fix!
>---
>
>diff --git a/drivers/net/ethernet/emulex/benet/be_ethtool.c
>b/drivers/net/ethernet/emulex/benet/be_ethtool.c
>index 63e51d4..59ee51a 100644
>--- a/drivers/net/ethernet/emulex/benet/be_ethtool.c
>+++ b/drivers/net/ethernet/emulex/benet/be_ethtool.c
>@@ -910,8 +910,9 @@ static void be_set_fw_log_level(struct be_adapter *adapter,
>u32 level)
> 	if (!status) {
> 		cfgs = (struct be_fat_conf_params *)(extfat_cmd.va +
> 					sizeof(struct be_cmd_resp_hdr));
>-		for (i = 0; i < cfgs->num_modules; i++) {
>-			for (j = 0; j < cfgs->module[i].num_modes; j++) {
>+		for (i = 0; i < le32_to_cpu(cfgs->num_modules); i++) {
>+			u32 num_modes = le32_to_cpu(cfgs-
>>module[i].num_modes);
>+			for (j = 0; j < num_modes; j++) {
> 				if (cfgs->module[i].trace_lvl[j].mode ==
> 								MODE_UART)
> 					cfgs->module[i].trace_lvl[j].dbg_lvl =
>diff --git a/drivers/net/ethernet/emulex/benet/be_main.c
>b/drivers/net/ethernet/emulex/benet/be_main.c
>index 501dfa9..bd5cf7e 100644
>--- a/drivers/net/ethernet/emulex/benet/be_main.c
>+++ b/drivers/net/ethernet/emulex/benet/be_main.c
>@@ -3479,7 +3479,7 @@ u32 be_get_fw_log_level(struct be_adapter *adapter)
> 	if (!status) {
> 		cfgs = (struct be_fat_conf_params *)(extfat_cmd.va +
> 						sizeof(struct be_cmd_resp_hdr));
>-		for (j = 0; j < cfgs->module[0].num_modes; j++) {
>+		for (j = 0; j < le32_to_cpu(cfgs->module[0].num_modes); j++) {
> 			if (cfgs->module[0].trace_lvl[j].mode == MODE_UART)
> 				level = cfgs->module[0].trace_lvl[j].dbg_lvl;
> 		}
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html