lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 Jul 2012 12:02:08 -0300 From: Kleber Sacilotto de Souza <klebers@...ux.vnet.ibm.com> To: Shlomo Pongartz <shlomop@...lanox.com> CC: Or Gerlitz <or.gerlitz@...il.com>, David Miller <davem@...emloft.net>, netdev@...r.kernel.org, jackm@....mellanox.co.il, yevgenyp@...lanox.co.il, ogerlitz@...lanox.com, cascardo@...ux.vnet.ibm.com, brking@...ux.vnet.ibm.com Subject: Re: [PATCH] mlx4: Add support for EEH error recovery On 07/25/2012 11:47 AM, Shlomo Pongartz wrote: > On 7/25/2012 1:30 AM, Or Gerlitz wrote: >> On Wed, Jul 25, 2012 at 12:03 AM, David Miller <davem@...emloft.net> wrote: >> >>> Or, you promised an ACK today, I still haven't seen it. >> It turned out that reacted we did, but not the ACK way. >> >> Again, code review wise, we intended to ack it, but Shlomo has set >> testing environment, under which he had some issues with the patch, as >> such he preferred not to ACK it but rather bring up the issues on the >> list and sort them out 1st. I thought it would be wrong to over-rule >> this preference of him, and this way is fair-enough with the author >> and your guide-lines, maybe I had to be more aggressive with ACKing >> this, as of the merge window closing coming. So tomorrow. >> >> Or. >> >>> There is no reason Kleber should be penalized and have his work >>> miss the merge window just because you guys can't be bothered >>> to approve this patch in a reasonable amount of time. >>> >>> Therefore I'm just going to apply it later today, and don't do this >>> with someone's submission ever again, it impedes progress and >>> frustrates contributors. >> . >> > > Hi Kleber, > > > > I reviewed the patch and it seems fine, here's my ACK > > > > Acked-by: Shlomo Pongratz <shlomop@...lanox.com > <mailto:shlomop@...lanox.com>> > > Hi Shlomo, Thank you for reviewing my patch. -- Kleber Sacilotto de Souza IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists