lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 2 Aug 2012 11:35:42 +0300 From: Erez Shitrit <erezsh@...lanox.com> To: Ben Hutchings <bhutchings@...arflare.com> CC: Or Gerlitz <ogerlitz@...lanox.com>, <davem@...emloft.net>, <roland@...nel.org>, <netdev@...r.kernel.org>, <ali@...lanox.com>, <sean.hefty@...el.com>, Erez Shitrit <erezsh@...lanox.co.il> Subject: Re: [PATCH V2 08/12] net/eipoib: Add ethtool file support On 8/2/2012 3:22 AM, Ben Hutchings wrote: > On Wed, 2012-08-01 at 20:09 +0300, Or Gerlitz wrote: >> From: Erez Shitrit <erezsh@...lanox.co.il> >> >> Via ethtool the driver describes its version, ABI version, on what PIF >> interface it runs and various statistics. > [...] >> --- /dev/null >> +++ b/drivers/net/eipoib/eth_ipoib_ethtool.c > [...] >> +static void parent_ethtool_get_drvinfo(struct net_device *parent_dev, >> + struct ethtool_drvinfo *drvinfo) >> +{ >> + struct parent *parent = netdev_priv(parent_dev); >> + >> + strncpy(drvinfo->driver, DRV_NAME, 32); >> + >> + strncpy(drvinfo->version, DRV_VERSION, 32); >> + >> + strncpy(drvinfo->bus_info, parent->ipoib_main_interface, >> + ETHTOOL_BUSINFO_LEN); > These must be null-terminated; therefore use strlcpy(). ok, will fix. >> + /* indicates ABI version */ >> + snprintf(drvinfo->fw_version, 32, "%d", EIPOIB_ABI_VER); > [...] > > This is an abuse of fw_version. > > Ben. we took the idea from the bonding driver, (snprintf(drvinfo->fw_version, 32, "%d", BOND_ABI_VERSION);) Do you have any idea where can we keep the abi version? Thanks, Erez -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists