netdev - Re: [PATCH net-next] ipv4: change inet_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 04 Aug 2012 01:28:12 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ipv4: change inet_addr_hash()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sat, 04 Aug 2012 09:06:50 +0200

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Use net_hash_mix(net) instead of hash_ptr(net, 8), and use
> hash_32() instead of using a serie of XOR
> 
> Define IN4_ADDR_HSIZE_SHIFT for clarity
> 
> __ip_dev_find() can perform the net_eq() call only if ifa_local
> matches the key, to avoid unneeded dereferences.
> 
> remove inline attributes
> 
> # size net/ipv4/devinet.o.before net/ipv4/devinet.o
>    text	   data	    bss	    dec	    hex	filename
>   17471	   2545	   2048	  22064	   5630	net/ipv4/devinet.o.before
>   17335	   2545	   2048	  21928	   55a8	net/ipv4/devinet.o
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html