netdev - Re: [PATCH] codel: refine one condition to avoid a nul rec_inv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 10 Aug 2012 16:54:05 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, lp2s1h@...il.com
Subject: Re: [PATCH] codel: refine one condition to avoid a nul rec_inv_sqrt

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 10 Aug 2012 17:16:11 +0200

> On Mon, 2012-07-30 at 14:54 -0700, David Miller wrote:
>> From: Eric Dumazet <eric.dumazet@...il.com>
>> Date: Mon, 30 Jul 2012 08:52:21 +0200
>> 
>> > From: Eric Dumazet <edumazet@...gle.com>
>> > 
>> > One condition before codel_Newton_step() was not good if
>> > we never left the dropping state for a flow. As a result
>> > rec_inv_sqrt was 0, instead of the ~0 initial value.
>> > 
>> > codel control law was then set to a very aggressive mode, dropping
>> > many packets before reaching 'target' and recovering from this problem.
>> > 
>> > To keep codel_vars_init() as efficient as possible, refine
>> > the condition to make sure rec_inv_sqrt initial value is correct
>> > 
>> > Many thanks to Anton Mich for discovering the issue and suggesting
>> > a fix.
>> > 
>> > Reported-by: Anton Mich <lp2s1h@...il.com>
>> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>> 
>> Applied and queued up for -stable.
> 
> Hi David, I think this patch got lost somehow ?

Thanks for catching this, I've corrected it now.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html