lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Aug 2012 17:37:11 +1000 From: Benjamin Herrenschmidt <benh@...nel.crashing.org> To: David Miller <davem@...emloft.net> Cc: mchan@...adcom.com, netdev@...r.kernel.org Subject: Re: [PATCH 0/4 v3 net-next] tg3: Add hwmon support On Mon, 2012-07-16 at 23:11 -0700, David Miller wrote: > From: "Michael Chan" <mchan@...adcom.com> > Date: Mon, 16 Jul 2012 19:23:58 -0700 > > > David, I've removed the binary sysfs attribute and now use > > hwmon only. Please consider this patchset for net-next. > > Applied, thanks Michael. > > You might want to add some Kconfig logic so that it's easier > to get the hwmon stuff automatically when tg3 is selected. Right, just got bitten by that one with one of my test configs: CONFIG_TIGON3=y CONFIG_HWMON=m results in: drivers/built-in.o: In function `.tg3_close': tg3.c:(.text+0x1ab664): undefined reference to `.hwmon_device_unregister' drivers/built-in.o: In function `.tg3_hwmon_open': tg3.c:(.text+0x1b153c): undefined reference to `.hwmon_device_register' I hit a similar one a while back with some DRM driver, there's no nice way to solve them afaik, other than basically forcing HWMON to y if TIGON3 is enabled. Either that, or having TIGON3's hwmon support be a sub-option itself dependent on CONFIG_HWMON & potentially build as a separate module etc... quite a pain. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists