netdev - Re: [PATCH] ipv4: Cache local output routes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 14 Aug 2012 14:47:29 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	zheng.z.yan@...el.com
Cc:	netdev@...r.kernel.org, alex.shi@...el.com
Subject: Re: [PATCH] ipv4: Cache local output routes

From: "Yan, Zheng" <zheng.z.yan@...el.com>
Date: Mon, 13 Aug 2012 14:09:59 +0800

> Commit caacf05e5ad1abf causes big drop of UDP loop back performance.
> The cause of the regression is that we do not cache the local output
> routes. Each time we send a datagram from unconnected UDP socket,
> the kernel allocates a dst_entry and adds it to the rt_uncached_list.
> It creates lock contention on the rt_uncached_lock.
> 
> Reported-by: Alex Shi <alex.shi@...el.com>
> Signed-off-by: Yan, Zheng <zheng.z.yan@...el.com>

I was pretty sure not using 'fi' was necessary for semantic
reasons here, but I can't find any such requirement, so I've
applied this, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html