netdev - Re: [PATCH v0 0/5] cgroup: Assign subsystem IDs during compile time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Aug 2012 15:05:42 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	Daniel Wagner <wagi@...om.org>
Cc:	netdev@...r.kernel.org, cgroups@...r.kernel.org,
	Daniel Wagner <daniel.wagner@...-carit.de>,
	"David S. Miller" <davem@...emloft.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Gao feng <gaofeng@...fujitsu.com>,
	Glauber Costa <glommer@...allels.com>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	John Fastabend <john.r.fastabend@...el.com>,
	Kamezawa Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Li Zefan <lizefan@...wei.com>, Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH v0 0/5] cgroup: Assign subsystem IDs during compile time

On Thu, Aug 16, 2012 at 04:12:11PM +0200, Daniel Wagner wrote:
> From: Daniel Wagner <daniel.wagner@...-carit.de>
> 
> Hi,
> 
> The patch #1 and #2 are there to be able to introduce (#3, #4) the 
> jump labels in task_cls_classid() and task_netprioidx(). The jump
> labels are needed to know when it is safe to access the controller. 
> For example not safe means the module is not yet loaded.
> 
> All those patches are just preparation for the center piece (#5) 
> of these series. This one will remove the dynamic subsystem ID
> generation and falls back to compile time generated IDs. 
> 
> This is the first result from the discussion around on the
> "cgroup cls & netprio 'cleanups'" patches.
> 
> This patches are against net-next
> 
> cheers,
> daniel
> 
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Gao feng <gaofeng@...fujitsu.com>
> Cc: Glauber Costa <glommer@...allels.com>
> Cc: Jamal Hadi Salim <jhs@...atatu.com>
> Cc: John Fastabend <john.r.fastabend@...el.com>
> Cc: Kamezawa Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> Cc: Li Zefan <lizefan@...wei.com>
> Cc: Neil Horman <nhorman@...driver.com>
> Cc: Tejun Heo <tj@...nel.org>
> Cc: netdev@...r.kernel.org
> Cc: cgroups@...r.kernel.org
> 
> Daniel Wagner (5):
>   cgroup: Use empty task_cls_classid() when !CONFIG_NET_CLS(_MODULE)
>   cgroup: Move sock_update_classid() decleration to cls_cgroup.h
>   cgroup: Protect access to task_cls_classid() when built as module
>   cgroup: Protect access to task_netprioidx() when built as module
>   cgroup: Assign subsystem IDs during compile time
> 
>  include/linux/cgroup.h        | 20 +++++++++++++-------
>  include/linux/cgroup_subsys.h | 24 ++++++++++++------------
>  include/net/cls_cgroup.h      | 42 +++++++++++++++++++++++++++++-------------
>  include/net/netprio_cgroup.h  | 23 +++++++++++------------
>  include/net/sock.h            |  8 --------
>  kernel/cgroup.c               | 31 +++++++++----------------------
>  net/core/netprio_cgroup.c     | 17 ++++++-----------
>  net/core/sock.c               | 12 ++++++------
>  net/sched/cls_cgroup.c        | 18 +++++-------------
>  9 files changed, 91 insertions(+), 104 deletions(-)
> 
> -- 
> 1.7.12.rc1.16.g05a20c8
> 
> 


The series seems reasonable.  I presume you've testing building and running both
net_prio and net_cls as modules and monolithically?
Neil

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html