| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 17 Aug 2012 15:38:36 +0200 From: Jiri Slaby <jslaby@...e.cz> To: davem@...emloft.net Cc: netdev@...r.kernel.org, jirislaby@...il.com, linux-kernel@...r.kernel.org, Jiri Slaby <jslaby@...e.cz>, Priyanka Jain <Priyanka.Jain@...escale.com> Subject: [PATCH] NET: xfrm, use correct rcu dereference helper Use rcu_dereference_bh while holding bh rcu lock. Otherwise we get: =============================== [ INFO: suspicious RCU usage. ] 3.6.0-rc1-next-20120816+ #10 Not tainted ------------------------------- net/xfrm/xfrm_policy.c:2504 suspicious rcu_dereference_check() usage! Signed-off-by: Jiri Slaby <jslaby@...e.cz> Cc: Priyanka Jain <Priyanka.Jain@...escale.com> --- net/xfrm/xfrm_policy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c index 5ad4d2c..6405764 100644 --- a/net/xfrm/xfrm_policy.c +++ b/net/xfrm/xfrm_policy.c @@ -2501,11 +2501,11 @@ static void __net_init xfrm_dst_ops_init(struct net *net) struct xfrm_policy_afinfo *afinfo; rcu_read_lock_bh(); - afinfo = rcu_dereference(xfrm_policy_afinfo[AF_INET]); + afinfo = rcu_dereference_bh(xfrm_policy_afinfo[AF_INET]); if (afinfo) net->xfrm.xfrm4_dst_ops = *afinfo->dst_ops; #if IS_ENABLED(CONFIG_IPV6) - afinfo = rcu_dereference(xfrm_policy_afinfo[AF_INET6]); + afinfo = rcu_dereference_bh(xfrm_policy_afinfo[AF_INET6]); if (afinfo) net->xfrm.xfrm6_dst_ops = *afinfo->dst_ops; #endif -- 1.7.11.5 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists