lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Aug 2012 09:00:26 +0200 From: Eric Dumazet <eric.dumazet@...il.com> To: "Eric W. Biederman" <ebiederm@...ssion.com> Cc: David Miller <davem@...emloft.net>, gaofeng@...fujitsu.com, netdev@...r.kernel.org, maheshb@...gle.com, therbert@...gle.com Subject: Re: [PATCH net-next v3] net: remove delay at device dismantle On Wed, 2012-08-22 at 23:34 -0700, Eric W. Biederman wrote: > raw_notifier_call_chain isn't safe without holding some sort of lock. > So removing the ASSERT_RTNL assert here is papering over a bug elsewhere > in this patch. > > Without holding a lock for traversing the notifier chain there will > be races with network module load and unload that could corrupt > this list while we are traversing it. > load/unlod. > > You already have one of your NETDEV_UNREGISTER_FINAL calls under the > rtnl_lock so it doesn't look like a burden to put the other call under > the rtnl_lock as well. Hmm right, I have been fooled by the rcu_dereference_raw() calls in notifier_call_chain() I'll send an update, thanks ! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists