lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:	Tue, 28 Aug 2012 21:05:16 +0800
From:	Wei Yongjun <weiyj.lk@...il.com>
To:	jon.maloy@...csson.com, allan.stephens@...driver.com,
	davem@...emloft.net
Cc:	yongjun_wei@...ndmicro.com.cn, netdev@...r.kernel.org,
	tipc-discussion@...ts.sourceforge.net
Subject: [PATCH] tipc: remove pointless conditional before kfree_skb()

From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

Remove pointless conditional before kfree_skb().

Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
---
 net/tipc/port.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/net/tipc/port.c b/net/tipc/port.c
index 07c42fb..9227d2c 100644
--- a/net/tipc/port.c
+++ b/net/tipc/port.c
@@ -770,8 +770,7 @@ static void port_dispatcher_sigh(void *dummy)
 				break;
 			}
 		}
-		if (buf)
-			kfree_skb(buf);
+		kfree_skb(buf);
 		buf = next;
 		continue;
 err:
@@ -819,8 +818,7 @@ err:
 				break;
 			}
 		}
-		if (buf)
-			kfree_skb(buf);
+		kfree_skb(buf);
 		buf = next;
 		continue;
 reject:

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ