netdev - RE: [PATCH] cxgb3: remove pointless conditional before kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 28 Aug 2012 14:24:37 +0100
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Wei Yongjun" <weiyj.lk@...il.com>, <divy@...lsio.com>
Cc:	<yongjun_wei@...ndmicro.com.cn>, <netdev@...r.kernel.org>
Subject: RE: [PATCH] cxgb3: remove pointless conditional before kfree_skb()

> -	if (t->nofail_skb)
> -		kfree_skb(t->nofail_skb);
> +	kfree_skb(t->nofail_skb);

Some of these conditionals might be there for performance
reasons - eg if common path and normally NULL.

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html