netdev - Re: [PATCH v3] net: add new QCA alx ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 31 Aug 2012 16:20:58 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	cjren@....qualcomm.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	qca-linux-team@...lcomm.com, nic-devel@...lcomm.com,
	xiong@....qualcomm.com, rodrigue@....qualcomm.com
Subject: Re: [PATCH v3] net: add new QCA alx ethernet driver

From: <cjren@....qualcomm.com>
Date: Tue, 28 Aug 2012 00:12:43 +0800

> +/*
> + * Definition to enable some features
> + */
> +#undef CONFIG_ALX_MSIX
> +#undef CONFIG_ALX_MSI
> +#undef CONFIG_ALX_MTQ
> +#undef CONFIG_ALX_MRQ
> +#undef CONFIG_ALX_RSS
> +/* #define CONFIG_ALX_MSIX */
> +#define CONFIG_ALX_MSI
> +#define CONFIG_ALX_MTQ
> +#define CONFIG_ALX_MRQ
> +#ifdef CONFIG_ALX_MRQ
> +#define CONFIG_ALX_RSS
> +#endif
> +

Get rid of all of these.  You may never use private feature control macros
in the CONFIG_* namespace, those are for the Kconfig system only.

Local controls of this nature are only appropriate for a driver amidst
development, and not a final version that should be included in the
upstream kernel tree.

You must remove all of these CPP macros, and all code that is currently
protected by the ones which are off.

Just so that your expectations are set appropriately, I anticipate
that there will be at least 5 more rounds of review for things of this
nature before we can even remotely consider adding this driver to the
tree.  This driver is very poorly written and is far away from meeting
our standards for incusion.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html