netdev - RE: Possible issue with Mellanox mlx4/port handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 3 Sep 2012 17:32:40 +0000
From:	Yevgeny Petrilin <yevgenyp@...lanox.com>
To:	"mleitner@...hat.com" <mleitner@...hat.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Or Gerlitz <ogerlitz@...lanox.com>
Subject: RE: Possible issue with Mellanox mlx4/port handling

> Commit
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=4c41b3673759d096106e68bce586f103c51d4119
> inserted changes like:
> 
> @@ -361,7 +361,7 @@ static int add_promisc_qp(struct mlx4_dev *dev, u8
> port,
>          int err;
>          struct mlx4_priv *priv = mlx4_priv(dev);
> 
> -       s_steer = &mlx4_priv(dev)->steer[0];
> +       s_steer = &mlx4_priv(dev)->steer[port - 1];
> 
>          mutex_lock(&priv->mcg_table.mutex);
> 
> But I fear we missed one part of the deal. Concept patch:
> 
> @@ -365,7 +365,7 @@ static int add_promisc_qp(struct mlx4_dev *dev, u8
> port,
> 
>          mutex_lock(&priv->mcg_table.mutex);
> 
> -       if (get_promisc_qp(dev, 0, steer, qpn)) {
> +       if (get_promisc_qp(dev, port - 1, steer, qpn)) {
>                  err = 0;  /* Noting to do, already exists */
>                  goto out_mutex;
>          }
> 
...
> 
> As far as I can understand, we are changing a list for a port and checking for
> duplicates on the other list. Points marked as A, B and C for highlighting. Am I
> missing something? What do you think?
> 
> FWIW, this call get_promisc_qp(dev, 0, ...) happens in other places too.
> 
> Thank you,
> Marcelo.

Hi Marcelo,
Thanks for this, You are absolutely right.
We actually have a fix for this issue which we are now verifying, and it will be sent to the mailing list in a few days.

Thanks,
Yevgeny
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html