netdev - Re: [PATCH 10/12] qlcnic: register dump utility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 6 Sep 2012 18:38:09 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Sony Chacko <sony.chacko@...gic.com>
CC:	<davem@...emloft.net>, <netdev@...r.kernel.org>,
	<Dept_NX_Linux_NIC_Driver@...gic.com>
Subject: Re: [PATCH 10/12] qlcnic: register dump utility

On Thu, 2012-09-06 at 02:22 -0400, Sony Chacko wrote:
> From: Sony Chacko <sony.chacko@...gic.com>
> 
> Modify 82xx driver to support new adapter - Qlogic 83XX CNA
> Common register dump utility for 82xx and 83xx adapters
[...]
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c
> @@ -525,21 +525,7 @@ static void qlcnic_get_channels(struct net_device *dev,
>  static int qlcnic_set_channels(struct net_device *dev,
>  		struct ethtool_channels *channel)
>  {
> -	struct qlcnic_adapter *adapter = netdev_priv(dev);
> -	int err;
> -
> -	if (channel->other_count || channel->combined_count ||
> -	    channel->tx_count != channel->max_tx)
> -		return -EINVAL;
> -
> -	err = qlcnic_validate_max_rss(dev, channel->max_rx, channel->rx_count);
> -	if (err)
> -		return err;
> -
> -	err = qlcnic_set_max_rss(adapter, channel->rx_count);
> -	netdev_info(dev, "allocated 0x%x sds rings\n",
> -				 adapter->max_sds_rings);
> -	return err;
> +	return 0;
>  }
[...]

No, I don't think so.  If you're going to remove support for this
operation then delete the function entirely.  And don't put it in a
patch that's supposed to do something unrelated.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html