netdev - Re: [PATCH net v2] ixp4xx_hss: fix build failure due to missing linux/module.h inclusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 10 Sep 2012 16:15:43 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	florian@...nwrt.org
Cc:	netdev@...r.kernel.org, khc@...waw.pl, joe@...ches.com,
	stable@...r.kernel.org
Subject: Re: [PATCH net v2] ixp4xx_hss: fix build failure due to missing
 linux/module.h inclusion

From: Florian Fainelli <florian@...nwrt.org>
Date: Mon, 10 Sep 2012 14:06:58 +0200

> Commit 36a1211970193ce215de50ed1e4e1272bc814df1 (netprio_cgroup.h:
> dont include module.h from other includes) made the following build
> error on ixp4xx_hss pop up:
> 
>   CC [M]  drivers/net/wan/ixp4xx_hss.o
>  drivers/net/wan/ixp4xx_hss.c:1412:20: error: expected ';', ',' or ')'
>  before string constant
>  drivers/net/wan/ixp4xx_hss.c:1413:25: error: expected ';', ',' or ')'
>  before string constant
>  drivers/net/wan/ixp4xx_hss.c:1414:21: error: expected ';', ',' or ')'
>  before string constant
>  drivers/net/wan/ixp4xx_hss.c:1415:19: error: expected ';', ',' or ')'
>  before string constant
>  make[8]: *** [drivers/net/wan/ixp4xx_hss.o] Error 1
> 
> This was previously hidden because ixp4xx_hss includes linux/hdlc.h which
> includes linux/netdevice.h which includes linux/netprio_cgroup.h which
> used to include linux/module.h. The real issue was actually present since
> the initial commit that added this driver since it uses macros from
> linux/module.h without including this file.
> 
> Signed-off-by: Florian Fainelli <florian@...nwrt.org>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html