lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 14 Sep 2012 07:36:31 +0200 From: Francois Romieu <romieu@...zoreil.com> To: Erwan Velu <erwanaliasr1@...il.com> Cc: David Miller <davem@...emloft.net>, netdev@...r.kernel.org Subject: Re: [PATCH] ipconfig: Inform user if carrier is not ready Erwan Velu <erwanaliasr1@...il.com> : [...] > This patch is just adding a simple message every second telling we are > waiting the carrier to come up. > --- > net/ipv4/ipconfig.c | 8 ++++++++ > 1 file changed, 8 insertions(+) The Signed-off-by: line is missing. > diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c > index 67e8a6b..d9f34b7 100644 > --- a/net/ipv4/ipconfig.c > +++ b/net/ipv4/ipconfig.c > @@ -205,6 +205,7 @@ static int __init ic_open_devs(void) > struct net_device *dev; > unsigned short oflags; > unsigned long start; > + unsigned int loops=0; (nit) unsigned int loops = 0; > last = &ic_first_dev; > rtnl_lock(); > @@ -266,6 +267,13 @@ static int __init ic_open_devs(void) > if (ic_is_init_dev(dev) && netif_carrier_ok(dev)) > goto have_carrier; > > + loops++; > + /* This loop is blocking the boot process until we get the > carrier or reach the timeout. Please split it into 80 cols max lines. [...] > + * Every second, we display a short message indicating we > wait the carrier */ (you can remove this part of the comment) -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists