netdev - Re: [PATCH net-next] gianfar: Change default HW Tx queue scheduling mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 24 Sep 2012 13:46:43 +0300
From:	Claudiu Manoil <claudiu.manoil@...escale.com>
To:	David Miller <davem@...emloft.net>
CC:	<netdev@...r.kernel.org>, <paul.gortmaker@...driver.com>
Subject: Re: [PATCH net-next] gianfar: Change default HW Tx queue scheduling
 mode

On 09/21/2012 08:35 PM, David Miller wrote:
> From: Claudiu Manoil <claudiu.manoil@...escale.com>
> Date: Thu, 20 Sep 2012 18:57:54 +0300
>
>> The TXSCHED setting may be changed at runtime, via sysfs, for devices
>> using multiple H/W Tx queues. For single queue devices this config
>> option is disabled, as the TXSCHED setting is superfluous in those cases.
>
> Please, no special driver specific sysfs knobs.
>
> Extend ethtool as necessary for your needs, so that any driver can
> provide this kind of configurability in a consistent way for users..
>
Ok.
Resent the patch addressing the watchdog timeout issue, without the 
runtime configuration part.
(see http://patchwork.ozlabs.org/patch/186315/).
This config option seems to be better off in a separate patch, 
especially if it would imply changes to ethtool.
What would you think of such an ethtool extension? Beside allowing the 
user to choose b/w letting the H/W to service its Tx queues equally or 
according to a built-in priority scheme, it could also provide api to 
configure scheduling weights per Tx queue for a weighted round-robin 
queue selection scheme, or, to configure only a single weight for all 
the queues (for a balanced scheme). (Are there currently other drivers/ 
devices that would use such an option?)

Thanks,
Claudiu


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html