[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 26 Sep 2012 15:24:03 +0800
From: Gao feng <gaofeng@...fujitsu.com>
To: Eric Dumazet <eric.dumazet@...il.com>
CC: davem@...emloft.net, netfilter-devel@...r.kernel.org,
linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
pablo@...filter.org, steffen.klassert@...unet.com,
linux-crypto@...r.kernel.org, jengelh@...i.de,
stephen.hemminger@...tta.com
Subject: Re: [PATCH 01/11] netlink: add reference of module in netlink_dump_start
于 2012年09月26日 15:07, Eric Dumazet 写道:
> On Wed, 2012-09-26 at 12:52 +0800, Gao feng wrote:
>
>> +int netlink_dump_done(struct netlink_callback *cb)
>> +{
>> + if (cb->module)
>> + module_put(cb->module);
>> + return 0;
>> +}
>> +EXPORT_SYMBOL(netlink_dump_done);
>> +
>
> No need to test cb->module being not NULL
>
>
> int netlink_dump_done(struct netlink_callback *cb)
> {
> module_put(cb->module);
> return 0;
> }
>
> Same remark for try_module_get() call
>
will fix it in v2 patchset.
thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists