lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 26 Sep 2012 18:14:45 +0200 From: Eric Dumazet <eric.dumazet@...il.com> To: Alexander Duyck <alexander.h.duyck@...el.com> Cc: David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH net-next] net: use bigger pages in __netdev_alloc_frag On Wed, 2012-09-26 at 09:00 -0700, Alexander Duyck wrote: > One minor thought. Instead of tracking offset and size why not just > work from the top down instead of the bottom up? > > So instead of starting with the frag offset at 0, why not start it at > PAGE_SIZE << order, and then work your way down to 0. That way you > don't need to track both size and offset. > How do you refill then ? (ie setting xxx->offset back to PAGE_SIZE << order) I am not sure we have direct access to a page order given a struct page pointer. I also like struct page_frag abstraction, because it might allow us better code factorization with other frag allocators. ( skb_append_datato_frags(), sk_page_frag_refill(), ...) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists