netdev - RE: [PATCH net-next] mlx4: dont orphan skbs in mlx4_en

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 30 Sep 2012 06:49:34 +0000
From:	Yevgeny Petrilin <yevgenyp@...lanox.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	"Or Gerlitz" <ogerlitz@...lanox.com>
Subject: RE: [PATCH net-next] mlx4: dont orphan skbs in mlx4_en_xmit()

Acked-by: Yevgeny Petrilin <yevgenyp@...lanox.com>

> -----Original Message-----
> From: Eric Dumazet [mailto:eric.dumazet@...il.com]
> Sent: Friday, September 28, 2012 7:54 PM
> To: Yevgeny Petrilin
> Cc: David Miller; netdev; Or Gerlitz
> Subject: [PATCH net-next] mlx4: dont orphan skbs in mlx4_en_xmit()
> 
> From: Eric Dumazet <edumazet@...gle.com>
> 
> After commit e22979d96a55d (mlx4_en: Moving to Interrupts for TX
> completions) we no longer need to orphan skbs in mlx4_en_xmit()
> since skb wont stay a long time in TX ring before their release.
> 
> Orphaning skbs in ndo_start_xmit() should be avoided as much as
> possible, since it breaks TCP Small Queue or other flow control
> mechanisms (per socket limits)
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Yevgeny Petrilin <yevgenyp@...lanox.com>
> Cc: Or Gerlitz <ogerlitz@...lanox.com>
> ---
>  drivers/net/ethernet/mellanox/mlx4/en_tx.c |    4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_tx.c
> b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
> index 10bba09..c10e3a6 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/en_tx.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
> @@ -712,10 +712,6 @@ netdev_tx_t mlx4_en_xmit(struct sk_buff *skb, struct net_device *dev)
>  	if (bounce)
>  		tx_desc = mlx4_en_bounce_to_desc(priv, ring, index, desc_size);
> 
> -	/* Run destructor before passing skb to HW */
> -	if (likely(!skb_shared(skb)))
> -		skb_orphan(skb);
> -
>  	if (ring->bf_enabled && desc_size <= MAX_BF && !bounce && !vlan_tag) {
>  		*(__be32 *) (&tx_desc->ctrl.vlan_tag) |= cpu_to_be32(ring->doorbell_qpn);
>  		op_own |= htonl((bf_index & 0xffff) << 8);
>