lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 5 Oct 2012 10:08:47 +0200 (CEST) From: Julia Lawall <julia.lawall@...6.fr> To: Joe Perches <joe@...ches.com> cc: Julia Lawall <julia.lawall@...6.fr>, David Miller <davem@...emloft.net>, peter.senna@...il.com, shemminger@...tta.com, mlindner@...vell.com, kernel-janitors@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 19/20] drivers/net/ethernet/marvell/skge.c: fix error return code On Fri, 5 Oct 2012, Joe Perches wrote: > On Fri, 2012-10-05 at 07:22 +0200, Julia Lawall wrote: >> A tool was used to find a potential problem, and then Peter >> studied the code to see what fix was appropriate. > > Hi Julia. > > Was it true that a static analysis tool found the original > potential issue? If so, what tool was it? In the very beginning, I think that I found the problem in a patch when looking at patches that contain oopses. >From that I wrote a Coccinelle rule. As Peter showed, the rule just produces a list of line numbers. The fix cannot easily be automated, because there are many cases where 0 is a valid error value. Some functions, for example, have their error value as a nonpositive integer. > But wasn't the scripted fix applied to the rest of the tree > robotically? No. Peter studied each case and considered what should be done, and then did that. I guess a potentially bad fix could have been applied automatically and then cleaned up manually, but considering the number of cases where the fix would be wrong, that seem like a bad idea. Also one might want to adapt a bit to local conventions about where the initialization should be added. julia -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists