lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 10 Oct 2012 14:05:01 +0200 From: Andreas Schwab <schwab@...ux-m68k.org> To: Joe Perches <joe@...ches.com> Cc: Dan Carpenter <dan.carpenter@...cle.com>, Karsten Keil <isdn@...ux-pingi.de>, "David S. Miller" <davem@...emloft.net>, Masanari Iida <standby24x7@...il.com>, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [patch] isdn: fix a wrapping bug in isdn_ppp_ioctl() Joe Perches <joe@...ches.com> writes: > @@ -589,16 +589,15 @@ isdn_ppp_ioctl(int min, struct file *file, unsigned int cmd, unsigned long arg) > break; > case PPPIOCGCOMPRESSORS: > { > - unsigned long protos[8] = {0,}; > + DECLARE_BITMAP(protos, BITS_PER_LONG * 8) = { 0, }; > struct isdn_ppp_compressor *ipc = ipc_head; > + > while (ipc) { > - j = ipc->num / (sizeof(long) * 8); > - i = ipc->num % (sizeof(long) * 8); > - if (j < 8) > - protos[j] |= (0x1 << i); > + if (ipc->num < BITS_PER_LONG * 8) > + set_bit(ipc->num, protos); > ipc = ipc->next; > } > - if ((r = set_arg(argp, protos, 8 * sizeof(long)))) > + if ((r = set_arg(argp, protos, sizeof(protos)))) This changes the bit endianess. Since protos is exported to user space it is an ABI change. Andreas. -- Andreas Schwab, schwab@...ux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists