netdev - Re: [PATCH v1] net/core: support runtime PM on net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Oct 2012 13:40:27 +0200
From:	Bjørn Mork <bjorn@...k.no>
To:	Ming Lei <ming.lei@...onical.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	"Rafael J. Wysocki" <rjw@...k.pl>, Oliver Neukum <oneukum@...e.de>,
	Alan Stern <stern@...land.harvard.edu>, netdev@...r.kernel.org,
	linux-pm@...r.kernel.org
Subject: Re: [PATCH v1] net/core: support runtime PM on net_device

Ming Lei <ming.lei@...onical.com> writes:
> On Thu, Oct 18, 2012 at 4:29 PM, Bjørn Mork <bjorn@...k.no> wrote:
>> Ming Lei <ming.lei@...onical.com> writes:
>>
>>> In ioctl path on net_device, the physical deivce is often
>>> touched, but the physical device may have been put into runtime
>>> suspend state already, so cause some utilitis(ifconfig, ethtool,
>>> ...) to return failure in this situation.
>>
>> I have to as the stupid questions again, sorry...
>>
>> Just wondering, isn't that really a driver problem?  The driver will
>
> It is or not, :-)
>
>> know whether or not hardware access is required, and should wake up the
>
> The netcore knows that first,  doesn't it？

Really? Does netcore know which ioctls the driver can handle without
waking the device?  You can of course do an educated guess, but I really
hate guesswork if there is a real answer somewhere else...

>> device if necessary.  Unless I misunderstand something here, this seems
>> like papering over driver bugs?
>
> Suppose it is driver bug, and basically most network drivers don't consider
> that, and we can fix that in netcore generally, so why bother all drivers to do
> that?

Because bugs are supposed to be fixed and not hidden?

Note that I am not claiming this is a bug.  That is still an open
question as far as I can see.



Bjørn
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html