netdev - RE: [PATCH 5/6] drivers: net: ethernet: cpts: implement cpts hardware clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 22 Oct 2012 10:55:55 +0000
From:	"N, Mugunthan V" <mugunthanvnm@...com>
To:	Richard Cochran <richardcochran@...il.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>
Subject: RE: [PATCH 5/6] drivers: net: ethernet: cpts: implement cpts
 hardware clock

> -----Original Message-----
> From: Richard Cochran [mailto:richardcochran@...il.com]
> Sent: Saturday, October 20, 2012 7:14 PM
> To: N, Mugunthan V
> Cc: netdev@...r.kernel.org; davem@...emloft.net
> Subject: Re: [PATCH 5/6] drivers: net: ethernet: cpts: implement cpts
> hardware clock
> 
> 
> I did a careful read of this driver, and I found a number of issues,
> but I am not giving a line by line review, for reasons explained
> below. For the most part, your driver is very similar to mine, and
> your driver would probably work fine too, when given a bit of review
> and revision. However, in the end, it would end up looking nearly
> identical to mine.
> 
> The issues about which you have voiced concern (counter roll over,
> changing input clock frequency) are by no means unique to the CPTS.
> The existing PHC drivers all handle these issues in a way consistent
> with each other. New drivers should not invent their own solutions to
> such problems.
> 
> If I had never written a CPTS driver and had seen your present
> submission first, then I would be willing to help you get your driver
> merged. But in my view, this work is already done, and so I am favoring
> my own driver at this point.
> 
> Here is my suggestion for moving forward with support the CPTS:
> 
> - It is too early to support the CPTS v1 found on the DM81xx, since
>   the CPSW support (including DT) is totally lacking. Judging from
>   your present driver and the TRM, the differences are minimal and
>   will be easy to add later on. For now, we can simply check the
>   version register for v2.
> 
> - If you can get the patches needed to get the CPSW working merged
>   during the present v3.7-rc interval, that would form a basis for
>   getting the CPTS into v3.8. I tried to post the patches that I had
>   collected, but I failed to get them all accepted. I really don't
>   know the issues surrounding those patches at all, and so I would
>   appreciate if you would take the lead and get this support merged.
> 
> - I will add a version check for CPTS v2 and integrate your CPSW
>   multicast patch (and anything else you think is missing) into my own
>   patch series. Once your background patches have appeared, I will
>   post the CPTS series for net-next, in time for v3.8.

The CPTS found in DM81XX and AM335X is of same version, only the CPSW version
is different in both SoCs.

Regards
Mugunthan V N

> 
> - Looking ahead, once you get a patch series to fully support the
>   DM81xx CPSW, we can patch the CPTS too.
> 
> Thanks,
> Richard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html