lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 22 Oct 2012 22:17:47 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Joe Perches <joe@...ches.com>
Cc:	davem@...emloft.net, Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com
Subject: Re: [net-next 08/12] ixgbe: using is_zero_ether_addr() to simplify
 the code

On Mon, 2012-10-22 at 21:45 -0700, Joe Perches wrote:
> On Mon, 2012-10-22 at 21:26 -0700, Jeff Kirsher wrote:
> > From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> > Using is_zero_ether_addr() to simplify the code.
> []
> > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c
> []
> > @@ -1778,8 +1778,7 @@ s32 ixgbe_validate_mac_addr(u8 *mac_addr)
> []
> > -	else if (mac_addr[0] == 0 && mac_addr[1] == 0 && mac_addr[2] == 0 &&
> > -	         mac_addr[3] == 0 && mac_addr[4] == 0 && mac_addr[5] == 0)
> > +	else if (is_zero_ether_addr(mac_addr))
> 
> This means the more comprehensive simplifying patch
> I submitted doesn't apply.  Easy to fix up though.
> 

Yeah, I have taken care of fix up to your patch in my queue.  Want me to
send you the fixed up patch so that you can confirm my fixes?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)

Powered by blists - more mailing lists