netdev - RE: [PATCH net-next 0/3] Enable PPS and PTP clocks automatically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 1 Nov 2012 18:59:57 +0000
From:	"Keller, Jacob E" <jacob.e.keller@...el.com>
To:	Ben Hutchings <bhutchings@...arflare.com>,
	Richard Cochran <richardcochran@...il.com>
CC:	David Miller <davem@...emloft.net>,
	Rodolfo Giometti <giometti@...eenne.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-net-drivers@...arflare.com" <linux-net-drivers@...arflare.com>
Subject: RE: [PATCH net-next 0/3] Enable PPS and PTP clocks automatically

> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org]
> On Behalf Of Ben Hutchings
> Sent: Thursday, November 01, 2012 9:47 AM
> To: Richard Cochran
> Cc: David Miller; Rodolfo Giometti; netdev@...r.kernel.org; linux-net-
> drivers@...arflare.com
> Subject: Re: [PATCH net-next 0/3] Enable PPS and PTP clocks automatically
> 
> On Thu, 2012-11-01 at 09:19 +0100, Richard Cochran wrote:
> > Ben,
> >
> > I really like this idea, but I have a couple of questions, below.
> >
> > On Thu, Nov 01, 2012 at 01:29:57AM +0000, Ben Hutchings wrote:
> >
> > > Ben Hutchings (3):
> > >   pps, ptp: Remove dependencies on EXPERIMENTAL
> >
> > Kees Cook just posted a massive series to remove EXPERIMENTAL
> > everywhere. Maybe it would make sense to have this series follow that
> > one?
> 
> If some other tree gets a commit to remove these, they should still
> merge cleanly.
> 
> > >   ptp: Make PTP_1588_CLOCK select rather than depend on PPS
> > >   ptp: Enable clock drivers along with associated net/PHY drivers
> > >
> > >  drivers/net/ethernet/intel/Kconfig                 |   28 +----------
> --------
> > >  drivers/net/ethernet/intel/igb/Makefile            |    4 +--
> > >  drivers/net/ethernet/intel/igb/igb.h               |    6 ----
> > >  drivers/net/ethernet/intel/igb/igb_ethtool.c       |    2 -
> > >  drivers/net/ethernet/intel/igb/igb_main.c          |   28 -----------
> ---------
> >
> > The #ifdefs in the Intel and PCH drivers are meant to streamline the
> > code for users who are not interested in time stamping. Although the
> > overhead of the additional is minimal (it really just a bunch of
> > tests), and I wouldn't mind removing the conditionals, I suspect that
> > some people won't like it.
> 
> Then they may object to this and maybe get some drivers changed back.
> However I didn't get any objections when I previously outlined these
> changes.
> 
> Ben.
> 
> --

Last I checked at least for ixgbe, we recently fixed the performance regression when PTP was enabled, and now it doesn't appear to cause lower performance when enabled in kernel but not enabled via the hwtstamp_ioctl.

- Jake