netdev - [PATCH] driver: net: ppp: change 8% to %s for seq_printf of pppoe_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 05 Nov 2012 19:31:27 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	David Miller <davem@...emloft.net>, kuznet@....inr.ac.ru,
	jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net
CC:	netdev <netdev@...r.kernel.org>
Subject: [PATCH] driver: net: ppp: change 8% to %s for seq_printf of pppoe_seq_show


  the length of po->pppoe_pa.dev is 16 (IFNAMSIZ)
  in seq_printf, it is not suitable to use %8s for po->pppoe_pa.dev.
  so change it to %s, since each line has not been solid any more.

Signed-off-by: Chen Gang <gang.chen@...anux.com>
---
 drivers/net/ppp/pppoe.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
index 20f31d0..7e89710 100644
--- a/drivers/net/ppp/pppoe.c
+++ b/drivers/net/ppp/pppoe.c
@@ -1009,7 +1009,7 @@ static int pppoe_seq_show(struct seq_file *seq,
void *v)
 	po = v;
 	dev_name = po->pppoe_pa.dev;

-	seq_printf(seq, "%08X %pM %8s\n",
+	seq_printf(seq, "%08X %pM %s\n",
 		po->pppoe_pa.sid, po->pppoe_pa.remote, dev_name);
 out:
 	return 0;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html