[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 6 Nov 2012 09:36:39 +0800
From: Frank Li <lznuaa@...il.com>
To: Richard Cochran <richardcochran@...il.com>
Cc: Frank Li <Frank.Li@...escale.com>, lznuaa@...il.com,
shawn.guo@...aro.org, linux-arm-kernel@...ts.infradead.org,
netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH 4/4] FEC: Add time stamping code and a PTP hardware clock
>> + Say Y here if you want to use PTP Hardware Clock (PHC) in the
>> + driver. Only the basic clock operations have been implemented.
>> +
>
> Does the PTP function work with every FEC on ColdFire and i.MX?
No, I just test i.MX.
>
> Or do you need to limit this option in some way?
Okay, I will do that at new patch because this patch have been accepted.
>
> You can reduce the time that the spin lock is held by moving the next
> four lines before the locked region:
>
>> + fep->cc.mult = FEC_CC_MULT;
>> + diff = fep->cc.mult;
>> + diff *= ppb;
>> + diff = div_u64(diff, 1000000000ULL);
>
Okay, I will do that at new patch and fix a bug when two boards
directly connect at 1G mode.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists