netdev - Re: [PATCH] usbnet: ratelimit kevent may have been dropped warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 12 Nov 2012 08:16:29 +0100
From:	Oliver Neukum <oneukum@...e.de>
To:	Steve Glendinning <steve.glendinning@...well.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] usbnet: ratelimit kevent may have been dropped warnings

On Thursday 08 November 2012 16:26:21 Steve Glendinning wrote:

> There's an underlying problem in usbnet's kevent deferral

This is imported from schedule_work().

> mechanism which needs fixing, specifically that events *can*
> get dropped and not handled.  This patch doesn't address this,
> but just mitigates fallout caused by the current implemention.

All is not lost, as the flag is still set. How about starting a timer
in the failure case? It feels kind of dirty, but a solution with locks would
leave open a window to a race in any case.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html