lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Nov 2012 07:30:22 -0800 From: Joe Perches <joe@...ches.com> To: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com> Cc: "David S. Miller" <davem@...emloft.net>, Francois Romieu <romieu@...zoreil.com>, Lennert Buytenhek <kernel@...tstofly.org>, netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, Jason Cooper <jason@...edaemon.net>, Andrew Lunn <andrew@...n.ch>, Gregory Clement <gregory.clement@...e-electrons.com>, Lior Amsalem <alior@...vell.com>, Dmitri Epshtein <dima@...vell.com> Subject: Re: [PATCH v6 2/7] net: mvneta: driver for Marvell Armada 370/XP network unit On Tue, 2012-11-13 at 16:00 +0100, Thomas Petazzoni wrote: > This patch contains a new network driver for the network unit of the > ARM Marvell Armada 370 and the Armada XP. Both SoCs use the PJ4B > processor, a Marvell-developed ARM core that implements the ARMv7 > instruction set. This looks very clean to me. trivial: some of the logging doesn't use terminating newlines. > +static int mvneta_check_mtu_valid(struct net_device *dev, int mtu) > +{ [] > + if (mtu > 9676) { > + netdev_info(dev, "Illegal MTU value %d, round to 9676", mtu); [] > + if (!IS_ALIGNED(MVNETA_RX_PKT_SIZE(mtu), 8)) { > + netdev_info(dev, "Illegal MTU value %d, rounding to %d", missing newlines > +static int __devinit mvneta_probe(struct platform_device *pdev) [] > + if (register_netdev(dev)) { > + dev_err(&pdev->dev, "failed to register\n"); > + err = ENOMEM; > + goto err_base; > + } [] > + dev_info(&pdev->dev, "%s, mac: %pM\n", dev->name, > + dev->dev_addr); You could use netdev_info here netdev_info(dev, "mac: %pM\n", dev->dev_addr); -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists