lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 Nov 2012 13:57:16 +0100 From: Jan Synacek <jsynacek@...hat.com> To: yoshfuji@...ux-ipv6.org Cc: netdev@...r.kernel.org, Jan Synacek <jsynacek@...hat.com> Subject: [PATCH 2/2] ping: Don't free an unintialized value. --- ping.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/ping.c b/ping.c index fe9ff8a..9de3d08 100644 --- a/ping.c +++ b/ping.c @@ -122,7 +122,7 @@ main(int argc, char **argv) u_char *packet; char *target; #ifdef USE_IDN - char *hnamebuf; + char *hnamebuf = NULL; #else char hnamebuf[MAX_HOSTNAMELEN]; #endif @@ -263,8 +263,10 @@ main(int argc, char **argv) #ifdef USE_IDN int rc; - free(hnamebuf); - hnamebuf = NULL; + if (hnamebuf) { + free(hnamebuf); + hnamebuf = NULL; + } rc = idna_to_ascii_lz(target, &idn, 0); if (rc != IDNA_SUCCESS) { -- 1.7.11.7 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists