lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Nov 2012 06:40:36 -0800 From: Tejun Heo <tj@...nel.org> To: Daniel Wagner <wagi@...om.org> Cc: serge.hallyn@...onical.com, ebiederm@...ssion.com, nhorman@...driver.com, tgraf@...g.ch, davem@...emloft.net, lizefan@...wei.com, cgroups@...r.kernel.org, containers@...ts.linux-foundation.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH 7/7] netprio_cgroup: allow nesting and inherit config on cgroup creation Hello, Daniel. On Tue, Nov 20, 2012 at 09:57:14AM +0100, Daniel Wagner wrote: > >-static void cgrp_css_free(struct cgroup *cgrp) > >+static int cgrp_css_online(struct cgroup *cgrp) > > { > >- struct cgroup_netprio_state *cs = cgrp_netprio_state(cgrp); > >+ struct cgroup *parent = cgrp->parent; > > struct net_device *dev; > >+ int ret = 0; > >+ > >+ if (!parent) > >+ return 0; > > BTW, parent is always != NULL, because the root cgroup will be > attached to the dummytop cgroup. Hmmm? I'm confused. When ->css_online() is called for dummytop in cgroup_init_subsys(), its parent is NULL. What am I missing? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists