lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 27 Nov 2012 09:23:20 -0800 From: Joe Perches <joe@...ches.com> To: Eric Dumazet <eric.dumazet@...il.com> Cc: David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>, Ling Ma <ling.ma.program@...il.com> Subject: Re: [PATCH net-next] net: move inet_dport/inet_num in sock_common On Tue, 2012-11-27 at 07:06 -0800, Eric Dumazet wrote: > From: Eric Dumazet <edumazet@...gle.com> > > commit 68835aba4d9b (net: optimize INET input path further) > moved some fields used for tcp/udp sockets lookup in the first cache > line of struct sock_common. [] > diff --git a/include/linux/ipv6.h b/include/linux/ipv6.h > index 5e11905..196ede4 100644 > --- a/include/linux/ipv6.h > +++ b/include/linux/ipv6.h > @@ -365,19 +365,21 @@ static inline struct raw6_sock *raw6_sk(const struct sock *sk) > #endif /* IS_ENABLED(CONFIG_IPV6) */ > > #define INET6_MATCH(__sk, __net, __hash, __saddr, __daddr, __ports, __dif)\ > + (((__sk)->sk_hash == (__hash)) && \ > + ((*((__portpair *)&(inet_sk(__sk)->inet_dport))) == (__ports)) && \ > + ((__sk)->sk_family == AF_INET6) && \ Perhaps these could be |'d together to avoid the test/jump after each comparison by using some bit operations instead. > + ipv6_addr_equal(&inet6_sk(__sk)->daddr, (__saddr)) && \ > + ipv6_addr_equal(&inet6_sk(__sk)->rcv_saddr, (__daddr)) && \ > + (!((__sk)->sk_bound_dev_if) || ((__sk)->sk_bound_dev_if == (__dif))) && \ > + net_eq(sock_net(__sk), (__net))) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists