netdev - Re: [PATCH] bonding: make arp_ip_target parameter checks consistent with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Nov 2012 17:33:56 +0100
From:	Nikolay Aleksandrov <nikolay@...hat.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org, andy@...yhouse.net, fubar@...ibm.com
Subject: Re: [PATCH] bonding: make arp_ip_target parameter checks consistent
 with sysfs

Actually I did see it from kernel/module.c and didn't come up with it 
myself.
Anyway I will re-post with the change and will take a note for the future.

Thanks for the review

On 28/11/12 17:23, David Miller wrote:
> From: Nikolay Aleksandrov<nikolay@...hat.com>
> Date: Sat, 24 Nov 2012 13:21:15 +0100
>
>> @@ -4706,12 +4706,14 @@ static int bond_check_params(struct bond_params *params)
>>   	     arp_ip_count++) {
>>   		/* not complete check, but should be good enough to
>>   		   catch mistakes */
>> -		if (!isdigit(arp_ip_target[arp_ip_count][0])) {
>> +		__be32 ip = in_aton(arp_ip_target[arp_ip_count]);
>> +		if (!isdigit(arp_ip_target[arp_ip_count][0])
>> +		    || ip == 0
>> +		    || ip == htonl(INADDR_BROADCAST)) {
> Please format this properly, put the connecting operators at the end,
> not the beginning, of the lines of the if statement, like so:
>
> 		if (!isdigit(arp_ip_target[arp_ip_count][0]) ||
> 		    ip == 0 ||
> 		    ip == htonl(INADDR_BROADCAST)) {
>
> Where else did you see the layout you used?  It's not a prevalent
> construct, so as far as I can tell you came up with it on your own.
>
> Please don't do this, and instead use existing practice as your guide.
>
> Thanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html