lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 01 Dec 2012 14:16:38 +0100
From:	Sven Eckelmann <sven@...fation.org>
To:	Antonio Quartulli <ordex@...istici.org>
Cc:	The list for a Better Approach To Mobile Ad-hoc
	 Networking <b.a.t.m.a.n@...ts.open-mesh.org>,
	netdev@...r.kernel.org
Subject: Re: Re: [B.A.T.M.A.N.] [PATCH 6/7] batman-adv: Allow to use rntl_link for device creation/deletion

Please don't remove netdev from this discussion without a reason.

On Saturday 01 December 2012 14:11:08 Antonio Quartulli wrote:
> On Sat, Nov 24, 2012 at 01:02:11AM +0100, Sven Eckelmann wrote:
> > The sysfs configuration interface of batman-adv to add/remove
> > soft-interfaces is not deadlock free and doesn't follow the currently
> > common way to create new virtual interfaces.
> > 
> > An additional interface though rtnl_link is introduced which provides easy
> > device creation/deletion with tools like "ip":
> > 
> > $ ip link add dev bat0 type batadv
> > $ ip link del dev bat0
> > 
> > Signed-off-by: Sven Eckelmann <sven@...fation.org>
> 
> Hello Sven,
> 
> why are we adding yet another API? What's the purpose? Is this intended to
> fix the lock bug we get while using sysfs?

Because this is the normal way to create virtual network devices (please feel 
free to correct me). And no, it doesn't fix the sysfs problem because the 
sysfs stuff isn't removed.

Kind regards,
	Sven
Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)

Powered by blists - more mailing lists