netdev - Re: [PATCH v3 1/4] net: Add support for hardware-offloaded encapsulation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 07 Dec 2012 14:28:45 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	joseph.gasparakis@...el.com
Cc:	bhutchings@...arflare.com, alexander.h.duyck@...el.com,
	shemminger@...tta.com, chrisw@...s-sol.org, gospo@...hat.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	dmitry@...adcom.com, saeed.bishara@...il.com,
	peter.p.waskiewicz.jr@...el.com
Subject: Re: [PATCH v3 1/4] net: Add support for hardware-offloaded
 encapsulation

From: Joseph Gasparakis <joseph.gasparakis@...el.com>
Date: Fri, 7 Dec 2012 10:24:17 -0800 (PST)

> So the idea here is that the driver will use the headers for checksumming 
> if the skb->encapsulation bit is on. The bit should be set in the protocol 
> driver.
> 
> To answer the second comment, the flags that we use in this series of 
> patches is NETIF_F_IP_CSUM, NETIF_F_IPV6_CSUM and NETIF_F_SG. These are 
> the bits that we propose will be used for checksumming of encapsulation. 
> As per a previous comment in v2, the hw_enc_features field should be used 
> also in the future when NICs have more encap offloads, so one could
> indicate these features there from the driver.
> 
> Furthermore, I submitted a patch for Rx checksumming, where NETIF_F_RXCSUM 
> is used, again in conjunction with skb->encapsulation flag. As I mention 
> in my logs, the driver is expected to set the ip_summed to UNNECESSARY and 
> turn the skb->encapsulation on, to indicate that the inner headers are 
> already HW checksummed.
> 

This is the kind of language that belongs in the commit message and
code comments.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html