lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 7 Dec 2012 16:27:43 +0000 From: Ben Hutchings <bhutchings@...arflare.com> To: Stanislaw Gruszka <sgruszka@...hat.com> CC: Eric Dumazet <edumazet@...gle.com>, <netdev@...r.kernel.org>, Ben Greear <greearb@...delatech.com>, <linux-wireless@...r.kernel.org>, Bjørn Mork <bjorn@...k.no> Subject: Re: [RFC] wireless: check against default_ethtool_ops On Fri, 2012-12-07 at 13:16 +0100, Stanislaw Gruszka wrote: > Since: > > commit 2c60db037034d27f8c636403355d52872da92f81 > Author: Eric Dumazet <edumazet@...gle.com> > Date: Sun Sep 16 09:17:26 2012 +0000 > > net: provide a default dev->ethtool_ops > > wireless core does not correctly assign ethtool_ops. In order to fix > the problem, and avoid assigning ethtool_ops on each individual cfg80211 > driver, we check against default_ethool_ops pointer instead of NULL in > wireless core. > > Signed-off-by: Stanislaw Gruszka <sgruszka@...hat.com> [...] Acked-by: Ben Hutchings <bhutchings@...arflare.com> Ideally you could do this assignment unconditionally in the setup function for the device, but it doesn't seem like there's a common allocation path that you could do that in. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists