lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 10 Dec 2012 15:16:23 +0530 From: Vipul Pandya <vipul@...lsio.com> To: David Miller <davem@...emloft.net> CC: "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "roland@...estorage.com" <roland@...estorage.com>, Divy Le Ray <divy@...lsio.com>, Dimitrios Michailidis <dm@...lsio.com>, Kumar A S <kumaras@...lsio.com>, Steve Wise <swise@...ngridcomputing.com>, Abhishek Agrawal <abhishek@...lsio.com> Subject: Re: [PATCH V3 1/5] cxgb4: Add T4 filter support On 04-12-2012 00:32, David Miller wrote: > From: Vipul Pandya <vipul@...lsio.com> > Date: Mon, 3 Dec 2012 16:52:57 +0530 > >> + /* >> + * If the new or old filter have loopback rewriteing rules then we'll >> + * need to free any existing Layer Two Table (L2T) entries of the old >> + * filter rule. The firmware will handle freeing up any Source MAC >> + * Table (SMT) entries used for rewriting Source MAC Addresses in >> + * loopback rules. >> + */ >> + if (f->l2t) >> + cxgb4_l2t_release(f->l2t); >> + >> + /* The zeroing of the filter rule below clears the filter valid, >> + * pending, locked flags, l2t pointer, etc. so it's all we need for >> + * this operation. >> + */ > > My greatest amusement is achieved when someone gets a code formatting > rule both correct and wrong in the same patch, as you have done here. > > Format comments in the networking: > > /* Like > * this. > */ > > /* > * Never, > * like this. > */ > > Thanks. > I have submitted the series again making above changes. Thanks for pointing out the same. I wonder how checkpatch.pl did not complain or gave a warning for the incorrect commenting style. I corrected only those comments for which checkpatch.pl gave me a warning. So, I think there are some checks missing in checkpatch.pl script. Thanks, Vipul -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists