netdev - Re: netdevice wanrouter: Convert directly reference of netdev->priv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Dec 2012 13:43:10 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	dan.carpenter@...cle.com
Cc:	wangchen@...fujitsu.com, netdev@...r.kernel.org
Subject: Re: netdevice wanrouter: Convert directly reference of netdev->priv

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Mon, 3 Dec 2012 12:04:05 +0300

> I suspect we should just revert the patch?

That is absolutely something we cannot do.

netdev->priv no longer exists, first of all.

And the whole point of this change was to allow us to
remove any and all references to netdev->priv, exactly
so that we could remove it altogether.

If you look at the commit in question, the idea is to
allocate the netdev in the ->new_if() callback.

And that's in fact what happens.

What's missing at the top level is something like:

	dev = wandev->dev;

And perhaps removing the 'dev' argument to the ->new_if()
method since it obviously is always NULL and never actually
used.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html