lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Dec 2012 12:07:43 +0200 From: Amir Vadai <amirv@...lanox.com> To: Brian Haley <brian.haley@...com> CC: "David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>, "Or Gerlitz" <ogerlitz@...lanox.com>, Yan Burman <yanb@...lanox.com> Subject: Re: [PATCH net-next 2/2] net/mlx4_en: Add support for destination MAC in steering rules On 11/12/2012 17:38, Brian Haley wrote: > On 12/11/2012 07:03 AM, Amir Vadai wrote: >> --- a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c >> +++ b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c >> @@ -619,7 +619,13 @@ static int mlx4_en_validate_flow(struct net_device *dev, >> if (cmd->fs.location >= MAX_NUM_OF_FS_RULES) >> return -EINVAL; >> >> - switch (cmd->fs.flow_type & ~FLOW_EXT) { >> + if (cmd->fs.flow_type & FLOW_MAC_EXT) { >> + /* dest mac mask must be ff:ff:ff:ff:ff:ff */ >> + if (memcmp(cmd->fs.m_ext.h_dest, &full_mac, ETH_ALEN)) >> + return -EINVAL; >> + } > > etherdevice.h has is_broadcast_ether_addr() and is_zero_ether_addr() if you want > to get rid of full_mac and zero_mac in this function. > > -Brian > Right, will send a V1 with this fix. Amir. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists