lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 22 Dec 2012 19:33:14 +0100 From: Stephan Gatzka <stephan.gatzka@...il.com> To: Stefan Richter <stefanr@...6.in-berlin.de> CC: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>, netdev@...r.kernel.org, linux1394-devel@...ts.sourceforge.net Subject: Re: IPv6 over Firewire > > You could add another case to include/net/ndisc.h::ndisc_addr_option_pad() > with a hardcoded size, couldn't you? > No, I think that is almost certainly not a good idea. The address space option is handed over to the firewire_net driver like this: type, length, soure/target link address (GUID) If I add another case in ndisc_addr_option_pad() I think the option will look like this: pad, type, length, soure/target link address (GUID) Because pad, type and GUID are already at the correct position for the 3146 link layer option. So with padding I have to copy them to the correct position. All I need is some (8 bytes) of additional tail room in the ndisc skb. This could be achieved either by specifying needed_tailroom in the firewire netdevice struct at the expense that now every skb allocated might get 8 bytes more allocated. The second option is yoshfuji suggestion to pimp ndisc_opt_addr_space a bit. His solution only allocates additional memory for ndisc packets at the expense to introduce a dependency to the struct ndisc_opt_ieee1394_llinfo. These are the two option we can go for. Personally I think reserving a bit more tail room looks cleaner if nobody votes against it... Regards, Stephan -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists