netdev - Re: net: usb: cdc_ncm: add support IFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 8 Jan 2013 23:24:06 +0100
From:	Alexey Orishko <alexey.orishko@...il.com>
To:	Wei Shuai <cpuwolf@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alexey Orishko <alexey.orishko@...il.com>,
	Hans Petter Selasky <hans.petter.selasky@...ricsson.com>,
	linux-usb@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: net: usb: cdc_ncm: add support IFF_NOARP

Hi,

On Tue, Jan 8, 2013 at 2:14 PM, Wei Shuai <cpuwolf@...il.com> wrote:
> Hi Alexey,
>         Recently I met a Modem which cannot do ARP. But I found our
> cdc_ncm_bind() function cannot handle this special case. Do you have any
> plan to handle it?
>
>
> static int cdc_ncm_bind(struct usbnet *dev, struct usb_interface *intf)
> {
>         ...
>         /*  cannot do ARP */
>         dev->net->flags |= IFF_NOARP;
>         ...
> }

All devices I have can handle ARP, so there was no need for such a
feature in the driver..

Last version of the driver also supports MBIM devices, which have no
MAC address at all
since payload is a pure IP, While considering changes this shall be
taken into account.

There is no way to find out if ARP is supported or not by looking at
CDC Ethernet
Networking or NCM Functional Descriptors. If control that flag to be
added to the driver,
it shall be based on matching VID/PID.

Regards,
Alexey
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html